Summary

Implements S4: Pre-commit Hooks from the SDLC plan.

Changes

1. Local pre-commit hooks via lefthook.yml:

   • gofmt - checks code formatting
   • goimports - checks import formatting
   • golangci-lint - runs linter on staged files
   • All run in parallel for speed

2. CI PR title validation:

   • New pr-title job validates PR titles follow conventional commits
   • Uses amannn/action-semantic-pull-request@v5
   • Ensures squash-merge commit messages are properly formatted

3. MASTER.md updated:

   • Marked S4 as complete (🟢)

Architecture

Local:     pre-commit → fmt/lint checks → commit-msg → commitlint
CI:        PR opened → pr-title job validates conventional format
Merge:     Squash uses PR title (validated by CI)

Note on Branch Rulesets

GitHub's commit_message_pattern ruleset feature is not available in the free tier. The implementation relies on:

• Local pre-commit hooks (can be bypassed with --no-verify)
• CI PR title validation (cannot be bypassed)

For enterprise repos, branch rulesets can be added via GitHub UI for additional enforcement.

Test Plan

• Ran make fmt && make lint && make test - all pass
• Committed changes - pre-commit hooks executed successfully
• Commit message validated by commitlint hook

To test locally:

# Update hooks
make setup-hooks

# Try committing unformatted code
echo "package main;func main(){}" > test.go
git add test.go
git commit -m "test: formatting check"  # Should fail pre-commit

Made with Cursor

Summary by CodeRabbit

• Chores
  • Added CI check to validate pull request titles automatically.
  • Configured pre-commit hooks to enforce formatting, import ordering, and linting for Go and to validate commit messages.
  • Updated internal project plan statuses to mark two previously deferred items as complete.